Comments on: What’s In A Code Review? http://www.xerxesb.com/2009/whats-in-a-code-review/ 'Cause there are some things you just *can't* get from a book... Fri, 12 Nov 2010 21:27:27 +0000 hourly 1 http://wordpress.org/?v= By: Ken Olofsen http://www.xerxesb.com/2009/whats-in-a-code-review/comment-page-1/#comment-3186 Ken Olofsen Thu, 12 Feb 2009 17:29:10 +0000 http://www.xerxesb.com/?p=338#comment-3186 <a href="#comment-3127" rel="nofollow">@Xerxes</a> Xerxes, I am confident the next release will address your concerns (and hopefully a bit more, too.. ;). Stay tuned! ko @Xerxes

Xerxes, I am confident the next release will address your concerns (and hopefully a bit more, too.. ;) . Stay tuned!

ko

]]> By: Xerxes http://www.xerxesb.com/2009/whats-in-a-code-review/comment-page-1/#comment-3127 Xerxes Tue, 10 Feb 2009 09:57:24 +0000 http://www.xerxesb.com/?p=338#comment-3127 <a href="#comment-3104" rel="nofollow">@Ken Olofsen</a> Hi Ken thanks for your comment. Our biggest drawback was the friction in getting Crucible/FishEye integrated seamlessly with our JIRA workflow. The products themselves seemed good enough (the little amount we actually used it ;)) What we were wanting was for a developer to complete a task, move it into a "For Review" status, assigned to a reviewer. The reviewer would initiate the Crucible review, make any necessary comments and the act of closing the review would send the JIRA item either back into development (if rework was required) or send it onto test (if there was no further work required). From memory, the biggest pain we experienced was that Crucible couldn't change the state of the JIRA workflow item. Another thing (which only just comes to mind) is that the Crucible review tab was not integrated with the "All Items" tab for a JIRA item, so we couldn't see (in chronological order) when reviews were conducted. All that could have changed in the next release, so i'm looking forward to seeing it! Thanks! :) @Ken Olofsen
Hi Ken thanks for your comment. Our biggest drawback was the friction in getting Crucible/FishEye integrated seamlessly with our JIRA workflow. The products themselves seemed good enough (the little amount we actually used it ;) )

What we were wanting was for a developer to complete a task, move it into a “For Review” status, assigned to a reviewer. The reviewer would initiate the Crucible review, make any necessary comments and the act of closing the review would send the JIRA item either back into development (if rework was required) or send it onto test (if there was no further work required).

From memory, the biggest pain we experienced was that Crucible couldn’t change the state of the JIRA workflow item. Another thing (which only just comes to mind) is that the Crucible review tab was not integrated with the “All Items” tab for a JIRA item, so we couldn’t see (in chronological order) when reviews were conducted.

All that could have changed in the next release, so i’m looking forward to seeing it!

Thanks! :)

]]> By: Ken Olofsen http://www.xerxesb.com/2009/whats-in-a-code-review/comment-page-1/#comment-3104 Ken Olofsen Mon, 09 Feb 2009 18:03:02 +0000 http://www.xerxesb.com/?p=338#comment-3104 Great post, Xerxes. I'm with Atlassian and I am curious to know what kind of problems you feel we need to address.. The next release is definitely focusing on making the process more seamless. Thx, ko Great post, Xerxes.

I’m with Atlassian and I am curious to know what kind of problems you feel we need to address.. The next release is definitely focusing on making the process more seamless.

Thx, ko

]]> By: Gregg Sporar http://www.xerxesb.com/2009/whats-in-a-code-review/comment-page-1/#comment-3103 Gregg Sporar Mon, 09 Feb 2009 17:05:30 +0000 http://www.xerxesb.com/?p=338#comment-3103 Making the process seamless is key - if developers can't easily create reviews and reviewers can't easily comment on the code and track what's been said, then it gets painful to use a tool for code review. We have put significant effort into streamlining the work flow in Code Collaborator; it would be great to get your feedback on it: http://smartbear.com/codecollab.php Making the process seamless is key – if developers can’t easily create reviews and reviewers can’t easily comment on the code and track what’s been said, then it gets painful to use a tool for code review. We have put significant effort into streamlining the work flow in Code Collaborator; it would be great to get your feedback on it: http://smartbear.com/codecollab.php

]]> By: Xerxes http://www.xerxesb.com/2009/whats-in-a-code-review/comment-page-1/#comment-3075 Xerxes Sun, 08 Feb 2009 21:56:21 +0000 http://www.xerxesb.com/?p=338#comment-3075 <a href="#comment-3059" rel="nofollow">@beefarino</a> We're a small team - about 6 of us in total. As far as tools go we're looking to improve our current process. We use JIRA for issue management and any outcomes from reviews are noted in JIRA and the issue assigned for rework back to the original developer. We started looking into Crucible and Fisheye for reviews but there were some problems with making the process seamless so we gave that up until it gets a bit better. @beefarino We’re a small team – about 6 of us in total.

As far as tools go we’re looking to improve our current process. We use JIRA for issue management and any outcomes from reviews are noted in JIRA and the issue assigned for rework back to the original developer. We started looking into Crucible and Fisheye for reviews but there were some problems with making the process seamless so we gave that up until it gets a bit better.

]]> By: beefarino http://www.xerxesb.com/2009/whats-in-a-code-review/comment-page-1/#comment-3059 beefarino Sun, 08 Feb 2009 13:44:27 +0000 http://www.xerxesb.com/?p=338#comment-3059 Xerxes; Nice post. I'm curious - how large is your team? Do you use any tools to track the reviews, or is it pretty informal? Xerxes;

Nice post. I’m curious – how large is your team?

Do you use any tools to track the reviews, or is it pretty informal?

]]> By: Chris Marisic http://www.xerxesb.com/2009/whats-in-a-code-review/comment-page-1/#comment-3004 Chris Marisic Fri, 06 Feb 2009 15:25:46 +0000 http://www.xerxesb.com/?p=338#comment-3004 I bet I would've induced shock on your manager in code reviews since frequently my bug fixes resulted in negative lines of code so my checked in file would have less lines than the previous file. I'm just picturing the does not compute expression on a managers face. Quite ironically the previous or next post whichever it is, is titled " Don’t Overcomplicate It - The Simple Solution Is Always The Best." I've always been a firm believer of "The best line of code I've ever written is the 10 I didn't." I bet I would’ve induced shock on your manager in code reviews since frequently my bug fixes resulted in negative lines of code so my checked in file would have less lines than the previous file. I’m just picturing the does not compute expression on a managers face.

Quite ironically the previous or next post whichever it is, is titled ” Don’t Overcomplicate It – The Simple Solution Is Always The Best.” I’ve always been a firm believer of “The best line of code I’ve ever written is the 10 I didn’t.”

]]>